But even if he did come from the future, it's not like there's any precedent for Barry remembering his past after he changes his own past. That episode in season 2 with Pied Piper and the entire beginning of season 3 proved that after changes are made to the timestream, those changes to not enter the time-altering Barry's mind.
I'm not saying Savitar/ Future Barry remembers his past after Barry changes his own past. I'm saying that he remembers his past when things have played out as they were, such as that confrontation with Killer Frost where she knew exactly what Barry was going to say and where Cisco would be. That was not a changed event.
What I'm saying is that if Future Barry is from a different timeline, then he can't remember the other Barry's past from the other timeline, because it is not even his past at all. It's effectively a different person's past.
It would be simpler to illustrate this with a graphic:
When Flashpoint occurs, Barry has an alternate timeline, represented by the black line and the letter B. If he continues down that timeline, everything happens along that path and he is not party to what happens on the red time line.
Barry in the non-Flashpoint timeline is represented by the red line and the letter A. If he goes back to the time before Flashpoint occurred (represented by that blue vertical line), instead of continuing on the black line, he now continues on the red line.
His conversation with Killer Frost in "I know who you are" occurred on May 2 2017 on the red time line. That is Barry's own history. When he went forward to 2024, that was also on the red time line. So everything that occurs on this red timeline, he should remember later on in the future.
But if Savitar comes from the black time line as a result of Flashpoint, he has not experienced any of the events of the red time line. So he can't have experienced that conversation with KF on May 2 2017 because it doesn't occur on the black line. It only happens on the red line. The black line is essentially a different path and a different life.
So in order for Savitar to know the events of May 2 2017 and all of Barry's history after Flashpoint (where there two lines diverge), he has to also be from the red time line, whether after 2024 or the morose Flash he met in 2024 who may have been deceiving him.
How can a Future Flash know and have experienced the events of both timelines unless he is somehow like Alchemy and can experience everything simultaneously no matter which path he is actually on?