I hope this movie does well. But you have the same writer, Simon Kinberg, who also wrote X3 and X:A. He also did DOFP, which is one of the best superhero movies ever, but that's still a 1:3 ratio. The person who wrote the 2 worst X-movies, both of which were horrible for the SAME reasons:
1) Inconsistent characters
2) Superficial dialogue
3) Not enough conflict, so uses characters as death fodder
And now he's not only writing but directing this new movie? The guy is talented--you can't write DOFP without serious skills. But it's hit and miss. Singer got blamed for X:A, after having a solid record with 3 other X-movies and he came up with the story for X:FC.
I am not optimistic about X-DP. I would LOVE to be wrong.
Even DoFP had many of the same problems as X:A.
In DoFP, we had death fodder characters (Bishop, Blink, Warpath, Sunspot, and even the off-screen departures of Banshee, Azazel, Emma and Angel Salvadore) and we also had the actual X-Men being a sideshow in their own movie.
DoFP got away with it because we had the familiarity/nostalgia of the original cast (we knew them already from at least three prior movies) and because deaths are far more expected in a horrifying dystopian world of mutant extinction that they are trying to prevent.
But then Kinberg used the same template for X:A. He opened with unfamiliar characters (Apocalypse and his cool mutant henchmen) and we didn't care about them because we didn't know them, then killed them off, quickly killed off classic characters (Angel and Havok this time, not Banshee and Emma). He tends to kill off characters when he has no more use for them, no idea what to do with them.
So I don't expect this to change in DP. It's how he thinks.
We will get undeveloped characters who are killed off (some of them will only be there to be killed off), the actual X-Men will be mostly a sideshow in their own movie (Storm, Nightcrawler and the new X-Men team members likely to be underdeveloped, maybe even Cyclops too).
There will be meaningless deaths just because he doesn't know what to do with the characters or thinks there should deaths to make the story have stakes and consequences, not because the deaths actually MEAN anything or actually MATTER.
So we can expect some of Lilandra's Imperial Guard and maybe the newly introduced X-Men members or even existing X-Men members to bite the dust in some faux drama that none of us care about.