To be fair, the way it was delivered in that movie was entirely different from the way Joss Whedon intended it to be delivered, so that's part of the reason why it sound so bad.
Whedon also contributed the exchange between Wolverine and Cyclops:
Wolverine: "You're a d***."
Cyclops: (takes hand away from visor laser eye release button) "....Ok."
and I went into this before on the boards, but I am not quite sure *how* Whedon would have wanted that Toad line delivered to make such a joke work.
The expected punchline to that joke is '..it croaks.'...so maybe he was subverting the expected line by having Storm saying something else, like, something that points out the obvious, with no punchline, and that was why it was supposed to be funny.
He has never said how it was supposed to be delivered, so I can only guess at how the joke was meant to work, but I don't think that joke is well known enough to work on an audience really. It's not like the chicken crossing the road gag, whose punchline 'to get to the other side' is the opposite kind of punchline to the toad one, but the same as the Storm subversion version in X-Men, where it is a pointing out the obvious 'punchline', with no word play.
and in other news....I noticed that the cop who has Kate as a prisoner in Lost, was the guy who Pierce Brosnan's Bond uses as a human grappling hook, so he can jump out of the window, in The World is not Enough.